8000 chore: remove dead versions that were missed by codyoss · Pull Request #6691 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

chore: remove dead versions that were missed #6691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codyoss merged 1 commit into from
Nov 5, 2019
Merged

chore: remove dead versions that were missed #6691

codyoss merged 1 commit into from
Nov 5, 2019

Conversation

@codyoss
Copy link
Member
8000
@codyoss codyoss commented Nov 4, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2019
@codecov
Copy link
codecov bot commented Nov 4, 2019

Codecov Report

Merging #6691 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6691      +/-   ##
============================================
+ Coverage     46.06%   46.35%   +0.28%     
- Complexity    28005    28021      +16     
============================================
  Files          2613     2613              
  Lines        287961   288098     +137     
  Branches      32916    33778     +862     
============================================
+ Hits         132647   133534     +887     
- Misses       144240   144319      +79     
+ Partials      11074    10245     -829
Impacted Files Coverage Δ Complexity Δ
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...le/cloud/storage/contrib/nio/CloudStoragePath.java 75.67% <0%> (-0.69%) 51% <0%> (ø)
...ge/contrib/nio/CloudStorageFileSystemProvider.java 62.76% <0%> (-0.3%) 73% <0%> (ø)
...ain/java/com/google/cloud/logging/LoggingImpl.java 87.9% <0%> (-0.19%) 73% <0%> (ø)
...ain/java/com/google/cloud/storage/StorageImpl.java 76.72% <0%> (-0.16%) 114% <0%> (+6%)
...m/google/cloud/spanner/jdbc/JdbcTypeConverter.java 74.86% <0%> (-0.14%) 88% <0%> (ø)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 87.67% <0%> (-0.13%) 165% <0%> (ø)
...src/main/java/io/grafeas/v1/UpdateNoteRequest.java 11.74% <0%> (-0.08%) 11% <0%> (ø)
...in/java/io/grafeas/v1/UpdateOccurrenceRequest.java 11.71% <0%> (-0.08%) 11% <0%> (ø)
...ava/io/grafeas/v1/ListNoteOccurrencesResponse.java 14.28% <0%> (-0.05%) 10% <0%> (ø)
... and 176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac6b4b6...f1eafb0. Read the comment docs.

@codyoss codyoss marked this pull request as ready for review November 5, 2019 03:23
@codyoss codyoss requested a review from a team November 5, 2019 03:24
@codyoss codyoss merged commit 5823621 into googleapis:master Nov 5, 2019
@codyoss codyoss deleted the cleanup-versions branch November 5, 2019 17:44
This was referenced Nov 6, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codyoss @BenWhitehead @googlebot
0