8000 Refresh VPCSC tests for monitoring V3 by steinwaywhw · Pull Request #6472 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Refresh VPCSC tests for monitoring V3 #6472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 2 commits into from
Oct 9, 2019
Merged

Refresh VPCSC tests for monitoring V3 #6472

chingor13 merged 2 commits into from
Oct 9, 2019

Conversation

@steinwaywhw
Copy link
Contributor
@steinwaywhw steinwaywhw commented Oct 9, 2019

The codegen was updated recently, as well as the protos. This is to refresh the auto-generated tests for VPCSC for the monitoring v3 clients.

@steinwaywhw
Refresh VPCSC tests for monitoring V3
bc19540 
The codegen was updated recently, as well as the protos. This is to refresh the auto-generated tests for VPCSC for the monitoring v3 clients.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2019
chingor13
chingor13 requested changes Oct 9, 2019
View reviewed changes
Copy link
Contributor
@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to a git mv to preserve any history (and to help with the diff)?

Also, do we need the "V3" in the class name (v3 is already in the java package)?

@codecov
Copy link
codecov bot commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #6472 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6472      +/-   ##
============================================
+ Coverage     46.06%   46.34%   +0.28%     
  Complexity    27974    27974              
============================================
  Files          2613     2613              
  Lines        287820   287955     +135     
  Branches      32895    33756     +861     
============================================
+ Hits         132575   133456     +881     
- Misses       144201   144279      +78     
+ Partials      11044    10220     -824
Impacted Files Coverage Δ Complexity Δ
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...le/cloud/storage/contrib/nio/CloudStoragePath.java 75.67% <0%> (-0.69%) 51% <0%> (ø)
...ge/contrib/nio/CloudStorageFileSystemProvider.java 62.76% <0%> (-0.3%) 73% <0%> (ø)
...ain/java/com/google/cloud/logging/LoggingImpl.java 87.9% <0%> (-0.19%) 73% <0%> (ø)
...ain/java/com/google/cloud/storage/StorageImpl.java 76.72% <0%> (-0.16%) 108% <0%> (ø)
...m/google/cloud/spanner/jdbc/JdbcTypeConverter.java 74.86% <0%> (-0.14%) 88% <0%> (ø)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 87.67% <0%> (-0.13%) 165% <0%> (ø)
...src/main/java/io/grafeas/v1/UpdateNoteRequest.java 11.74% <0%> (-0.08%) 11% <0%> (ø)
...in/java/io/grafeas/v1/UpdateOccurrenceRequest.java 11.71% <0%> (-0.08%) 11% <0%> (ø)
...ava/io/grafeas/v1/ListNoteOccurrencesResponse.java 14.28% <0%> (-0.05%) 10% <0%> (ø)
... and 175 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 553ab8e...0de4e79. Read the comment docs.

@steinwaywhw
Copy link
Contributor Author
steinwaywhw commented Oct 9, 2019

Sure. I removed the V3 from the name. Since the file is auto-generated, the diff probably does not mean anything to you. We just need to make sure the tests pass.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2019
@chingor13 chingor13 merged commit 9476314 into googleapis:master Oct 9, 2019
@chingor13 chingor13 mentioned this pull request Oct 9, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@steinwaywhw @chingor13 @googlebot @yoshi-kokoro
0