8000 recommend libraries-bom for troubleshooting by elharo · Pull Request #6463 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

recommend libraries-bom for troubleshooting #6463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 2 commits into from
Oct 9, 2019
Merged

recommend libraries-bom for troubleshooting #6463

chingor13 merged 2 commits into from
Oct 9, 2019

Conversation

@elharo
Copy link
Contributor
@elharo elharo commented Oct 8, 2019

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
@elharo elharo added semver: patch A minor bug fix or small change. type: docs Improvement to the documentation for an API. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 8, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
@elharo elharo requested a review from chingor13 October 8, 2019 21:05
@codecov
Copy link
codecov bot commented Oct 8, 2019 •
edited
Loading

Codecov Report

Merging #6463 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6463      +/-   ##
============================================
- Coverage     46.34%   45.98%   -0.37%     
+ Complexity    27976    26488    -1488     
============================================
  Files          2613     2613              
  Lines        287951   282565    -5386     
  Branches      33756    33559     -197     
============================================
- Hits         133461   129942    -3519     
+ Misses       144270   143366     -904     
+ Partials      10220     9257     -963
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...oogle/cloud/language/v1/LanguageServiceClient.java 79.16% <0%> (-2.32%) 26% <0%> (-9%)
...e/cloud/vision/v1p1beta1/ImageAnnotatorClient.java 42.3% <0%> (-2.14%) 6% <0%> (-1%)
...aming/v1alpha/GameServerClustersServiceClient.java 65.93% <0%> (-2.11%) 21% <0%> (-1%)
... and 642 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55bae7...8f344a5. Read the comment docs.

@chingor13 chingor13 merged commit f109c8a into master Oct 9, 2019
@chingor13 chingor13 deleted the i6395 branch October 9, 2019 21:40
@chingor13 chingor13 mentioned this pull request Oct 9, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. semver: patch A minor bug fix or small change. type: docs Improvement to the documentation for an API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TROUBLESHOOTING.md should reference BOM

3 participants

@elharo @chingor13 @googlebot
0