8000 Be more direct about setting up ADC by elharo · Pull Request #6457 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Be more direct about setting up ADC #6457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Oct 9, 2019
Merged

Be more direct about setting up ADC #6457

chingor13 merged 1 commit into from
Oct 9, 2019

Conversation

@elharo
Copy link
8000 Contributor
@elharo elharo commented Oct 8, 2019

Need application default credentials before the tests will pass, even with skipIts

@chingor13
Fixes #6456

@elharo
Be more direct about setting up ADC
db3bb07 
Need application default credentials before the tests will pass, even with skipIts

@chingor13 fix #6456
@elharo elharo requested a review from chingor13 October 8, 2019 13:04
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
@codecov
Copy link
codecov bot commented Oct 8, 2019 •
edited
Loading

Codecov Report

Merging #6457 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6457      +/-   ##
============================================
- Coverage     46.34%   46.34%   -0.01%     
- Complexity    27968    27984      +16     
============================================
  Files          2613     2613              
  Lines        287931   287931              
  Branches      33756    33751       -5     
============================================
- Hits         133452   133449       -3     
- Misses       144259   144262       +3     
  Partials      10220    10220
Impacted Files Coverage Δ Complexity Δ
.../cloud/datastore/testing/LocalDatastoreHelper.java 80.59% <0%> (-4.48%) 17% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d81a0f...db3bb07. Read the comment docs.

@chingor13 chingor13 merged commit 8895324 into master Oct 9, 2019
@chingor13 chingor13 deleted the elharo-patch-3 branch October 9, 2019 19:29
@chingor13 chingor13 mentioned this pull request Oct 9, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GrafeasInteropTest needs application default credentials

3 participants

@elharo @chingor13 @googlebot
0