[Bigtable] Overload MutationApi#setCell to accept long values #6432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulKQL
commented
Oct 3, 2019
...s/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Mutation.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #6432 +/- ##
============================================
+ Coverage 45.98% 46.34% +0.36%
- Complexity 26480 27976 +1496
============================================
Files 2613 2613
Lines 282539 287951 +5412
Branches 33559 33756 +197
============================================
+ Hits 129926 133461 +3535
- Misses 143357 144270 +913
- Partials 9256 10220 +964
Continue to review full report at Codecov.
|
igorbernstein2
suggested changes
Oct 3, 2019
There was a problem hiding this comment.
LGTM, but please add an integration test:
setCell(..., 0x12345678)
assertThat(readRow(...).getValue()).isEqualTo(ByteString.copyFrom(new byte[] {0, 0, 0, 0, 0x12, 0x34, 0x56, 0x78})
readModifyWrite to increment
assertThat(readRow(...).getValue()).isEqualTo(ByteString.copyFrom(new byte[] {0, 0, 0, 0, 0x12, 0x34, 0x56, 0x79})
...s/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Mutation.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Java-Bigtable#4
Added 4 overloaded methods in the
MutationApi& added test case for the same.