8000 Skip translate deployment from this repo by chingor13 · Pull Request #6418 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Skip translate deployment from this repo #6418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Oct 2, 2019
Merged

Skip translate deployment from this repo #6418

chingor13 merged 1 commit into from
Oct 2, 2019

Conversation

@chingor13
Copy link
Contributor
@chingor13 chingor13 commented Oct 2, 2019 •
edited
Loading

This will allow the tests to continue to run while we migrate to https://github.com/googleapis/java-translate. We will stop version bumping here and will not release this client as part of the batch release.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2019
@chingor13 chingor13 requested a review from a team October 2, 2019 20:17
@codecov
Copy link
codecov bot commented Oct 2, 2019 •
edited
Loading

Codecov Report

Merging #6418 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6418      +/-   ##
============================================
+ Coverage     45.98%   46.35%   +0.36%     
- Complexity    26494    28008    +1514     
============================================
  Files          2613     2613              
  Lines        282532   288065    +5533     
  Branches      33553    33755     +202     
============================================
+ Hits         129914   133524    +3610     
- Misses       143361   144321     +960     
- Partials       9257    10220     +963
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 55.09% <0%> (-7.79%) 147% <0%> (+36%)
...onitoring/v3/NotificationChannelServiceClient.java 64.49% <0%> (-7.13%) 43% <0%> (+10%)
...ava/com/google/cloud/compute/v1/ProjectClient.java 57.07% <0%> (-6.99%) 55% <0%> (+13%)
.../com/google/cloud/compute/v1/TargetPoolClient.java 57.73% <0%> (-6.98%) 47% <0%> (+11%)
...va/com/google/cloud/compute/v1/SnapshotClient.java 55.73% <0%> (-6.88%) 31% <0%> (+7%)
...oogle/cloud/kms/v1/KeyManagementServiceClient.java 62.88% <0%> (-6.84%) 103% <0%> (+25%)
...com/google/cloud/compute/v1/ReservationClient.java 59.14% <0%> (-6.83%) 39% <0%> (+9%)
...a/com/google/cloud/compute/v1/NodeGroupClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
.../com/google/cloud/compute/v1/SubnetworkClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
...d/compute/v1/RegionInstanceGroupManagerClient.java 54.5% <0%> (-6.79%) 51% <0%> (+12%)
... and 643 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730e2ba...83673bb. Read the comment docs.

@chingor13 chingor13 merged commit 7317ec6 into googleapis:master Oct 2, 2019
@chingor13 chingor13 deleted the skip-translate-release branch October 2, 2019 21:03
@chingor13 chingor13 mentioned this pull request Oct 2, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyoss codyoss codyoss approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @codyoss @googlebot
0