10BC0 Regenerate datacatalog client by yoshi-automation · Pull Request #6402 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Regenerate datacatalog client #6402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Oct 2, 2019
Merged

Regenerate datacatalog client #6402

chingor13 merged 1 commit into from
Oct 2, 2019

Conversation

@yoshi-automation
Copy link
Contributor
@yoshi-automation yoshi-automation commented Oct 1, 2019

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-datacatalog/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:6068f67900a3f0bdece596b97bda8fc70406ca0e137a941f4c81d3217c994a80
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/datacatalog/artman_datacatalog_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 10 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 96 files
synthtool > Cleaned up 1 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2019
@frankyn frankyn requested a review from shollyman October 1, 2019 21:56
shollyman
shollyman approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor
@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a large set of changes and new methods, so I'm relying on the fact that more incremental reviews were done upstream of this generation.

Many of the deltas are triggered by an increase in method/field comments and annotations (yay). There appears to be new alpha-yet-public additions to the API surface. The previously identified issue around field flattening for IAM methods is addressed here.

The service itself is beta and changes are expected, so approving.

@chingor13 chingor13 merged commit 05f522e into master Oct 2, 2019
@chingor13 chingor13 deleted the autosynth-datacatalog branch October 2, 2019 00:34
@chingor13 chingor13 mentioned this pull request Oct 2, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation @shollyman @chingor13 @googlebot
0