8000 Datastore : add GqlQuery#setBinding method which accept null value by athakor · Pull Request #6360 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Datastore : add GqlQuery#setBinding method which accept null value #6360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenWhitehead merged 4 commits into from
Oct 3, 2019
Merged

Datastore : add GqlQuery#setBinding method which accept null value #6360

BenWhitehead merged 4 commits into from
Oct 3, 2019

Conversation

@athakor
Copy link
Contributor
@athakor athakor commented Sep 26, 2019

Fixes #6357

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2019
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2019
@chingor13 chingor13 requested a review from BenWhitehead October 1, 2019 22:17
BenWhitehead
BenWhitehead suggested changes Oct 2, 2019
View reviewed changes
...-cloud-clients/google-cloud-datastore/src/main/java/com/google/cloud/datastore/GqlQuery.java Outdated
*
* @param name of the binding
*/
public Builder<V> setBinding(String name) {
Copy link
Contributor
@BenWhitehead BenWhitehead Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this method to setNullBinding so that the name of the method matches the behavior that is implemented.

Copy link
Contributor Author
@athakor athakor Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. PTAL

@codecov
Copy link
codecov bot commented Oct 3, 2019 •
edited
Loading

Codecov Report

Merging #6360 into master will decrease coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6360      +/-   ##
============================================
- Coverage     46.85%   46.34%   -0.51%     
+ Complexity    28122    27984     -138     
============================================
  Files          2601     2613      +12     
  Lines        287273   287931     +658     
  Branches      33361    33751     +390     
============================================
- Hits         134608   133452    -1156     
- Misses       142431   144259    +1828     
+ Partials      10234    10220      -14
Impacted Files Coverage Δ Complexity Δ
...main/java/com/google/cloud/datastore/GqlQuery.java 44.75% <100%> (+7.16%) 11 <0> (+2) ⬆️
...ud/bigtable/admin/v2/BigtableTableAdminClient.java 61.33% <0%> (-18.67%) 27% <0%> (ø)
...in/java/com/google/cloud/storage/PolicyHelper.java 95.23% <0%> (-4.77%) 7% <0%> (+1%)
...m/google/cloud/redis/v1beta1/CloudRedisClient.java 56.41% <0%> (-3.96%) 35% <0%> (ø)
...ain/java/com/google/cloud/storage/StorageImpl.java 76.72% <0%> (-1.66%) 114% <0%> (+14%)
.../main/java/com/google/cloud/compute/v1/UrlMap.java 30.7% <0%> (-1.48%) 22% <0%> (+3%)
...cloud/datacatalog/v1beta1/DataCatalogSettings.java 9.33% <0%> (-1.44%) 2% <0%> (ø)
...va/com/google/cloud/compute/v1/ForwardingRule.java 35.88% <0%> (-1.25%) 29% <0%> (+1%)
...loud/datacatalog/v1beta1/stub/DataCatalogStub.java 3.7% <0%> (-0.85%) 1% <0%> (ø)
...va/com/google/cloud/compute/v1/BackendService.java 32.24% <0%> (-0.81%) 34% <0%> (+4%)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5fbcd...8774b0b. Read the comment docs.

@BenWhitehead BenWhitehead merged commit cd38245 into googleapis:master Oct 3, 2019
@chingor13 chingor13 mentioned this pull request Oct 9, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BenWhitehead BenWhitehead

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

com.google.cloud.datastore.GqlQuery.Builder does not accept null values and results in an exception

4 participants

@athakor @BenWhitehead @googlebot @yoshi-kokoro
0