8000 Updated JavaDoc to mention connection pooling over ManagedChannel by rahulKQL · Pull Request #6328 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Updated JavaDoc to mention connection pooling over ManagedChannel #6328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorbernstein2 merged 3 commits into from
Oct 8, 2019
Merged

Updated JavaDoc to mention connection pooling over ManagedChannel #6328

igorbernstein2 merged 3 commits into from
Oct 8, 2019

Conversation

@rahulKQL
Copy link
@rahulKQL rahulKQL commented Sep 24, 2019

Fixes #5190

Updated JavaDoc at EnhancedBigtableStubSetting#defaultTransportChannelProvider to mention about connection pooling over ManagedChannel.

@rahulKQL rahulKQL added the api: bigtable Issues related to the Bigtable API. label Sep 24, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2019
igorbernstein2
igorbernstein2 reviewed Sep 24, 2019
View reviewed changes
Copy link
@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stub settings aren’t really visible to the user. I think this needs to be bubbled up to BigtableDataSettings’ class description

@codecov
Copy link
codecov bot commented Sep 24, 2019 •
edited
Loading

Codecov Report

Merging #6328 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6328      +/-   ##
============================================
+ Coverage     46.85%   46.85%   +<.01%     
- Complexity    28120    28122       +2     
============================================
  Files          2601     2601              
  Lines        287258   287273      +15     
  Branches      33359    33361       +2     
============================================
+ Hits         134595   134608      +13     
- Misses       142429   142431       +2     
  Partials      10234    10234
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigtable/data/v2/BigtableDataSettings.java 32.14% <ø> (ø) 4 <0> (ø) ⬇️
...c/main/java/com/google/cloud/bigquery/Dataset.java 88.7% <0%> (-2.96%) 16% <0%> (ø)
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java 98.56% <0%> (+0.01%) 20% <0%> (ø) ⬇️
...in/java/com/google/cloud/bigquery/DatasetInfo.java 95.75% <0%> (+0.33%) 33% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba66e6...f0feaf6. Read the comment docs.

@rahulKQL
Copy link
Author
rahulKQL commented Sep 24, 2019

Thanks! for the direction. I have added that change, PTAL.

igorbernstein2
igorbernstein2 approved these changes Oct 8, 2019
View reviewed changes
Copy link
@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorbernstein2 igorbernstein2 merged commit 8e747b2 into googleapis:master Oct 8, 2019
@chingor13 chingor13 mentioned this pull request Oct 9, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 Awaiting requested review from kolea2

2 more reviewers

@RahulKwani RahulKwani RahulKwani left review comments

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bigtable: Update docs to make it obvious that a connection pool is being used

4 participants

@rahulKQL @RahulKwani @igorbernstein2 @googlebot
0