8000 Bigtable: Updated Javadoc of models/CreateInstanceRequest.java by rahulKQL · Pull Request #6201 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Bigtable: Updated Javadoc of models/CreateInstanceRequest.java #6201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorbernstein2 merged 6 commits into from
Oct 8, 2019
Merged

Bigtable: Updated Javadoc of models/CreateInstanceRequest.java #6201

igorbernstein2 merged 6 commits into from
Oct 8, 2019

Conversation

@rahulKQL
Copy link
@rahulKQL rahulKQL commented Aug 30, 2019

Updated the javadoc to be consistent with instance.proto.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2019
@igorbernstein2 igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Aug 30, 2019
@rahulKQL rahulKQL requested a review from kolea2 September 12, 2019 05:59
@rahulKQL
Copy link
Author
rahulKQL commented Sep 24, 2019

@igorbernstein2 Whenever you get time, please have a look.

kolea2
kolea2 previously requested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor
@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry just saw the comment, will double check this is correct

@rahulKQL rahulKQL force-pushed the createInstanceJavadoc branch from f000ace to b142ad4 Compare October 1, 2019 11:03
@codecov
Copy link
codecov bot commented Oct 1, 2019 •
edited
Loading

Codecov Report

Merging #6201 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6201      +/-   ##
============================================
+ Coverage     46.29%   46.33%   +0.03%     
- Complexity    27922    27962      +40     
============================================
  Files          2613     2613              
  Lines        287626   287923     +297     
  Branches      33735    33755      +20     
============================================
+ Hits         133169   133418     +249     
- Misses       144252   144289      +37     
- Partials      10205    10216      +11
Impacted Files Coverage Δ Complexity Δ
...igtable/admin/v2/models/CreateInstanceRequest.java 97.43% <100%> (+0.46%) 9 <1> (+1) ⬆️
...ain/java/com/google/cloud/storage/StorageImpl.java 76.72% <0%> (-1.66%) 108% <0%> (+8%)
...cloud/datacatalog/v1beta1/DataCatalogSettings.java 9.33% <0%> (-1.44%) 2% <0%> (ø)
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 86.5% <0%> (-1%) 36% <0%> (-1%)
...loud/datacatalog/v1beta1/stub/DataCatalogStub.java 3.7% <0%> (-0.85%) 1% <0%> (ø)
...rc/main/java/com/google/cloud/storage/Storage.java 79.39% <0%> (-0.33%) 0% <0%> (ø)
...n/java/com/google/cloud/storage/SignatureInfo.java 78.51% <0%> (ø) 10% <0%> (ø) ⬇️
...urityscanner/v1alpha/WebSecurityScannerClient.java 66.5% <0%> (ø) 55% <0%> (ø) ⬇️
...ery/datatransfer/v1/DataTransferServiceClient.java 65.35% <0%> (ø) 55% <0%> (ø) ⬇️
...1beta1/PhishingProtectionServiceV1Beta1Client.java 44.11% <0%> (ø) 7% <0%> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f6202...e1096d9. Read the comment docs.

igorbernstein2
igorbernstein2 approved these changes Oct 1, 2019
View reviewed changes
Copy link
@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

@rahulKQL rahulKQL requested a review from kolea2 October 2, 2019 13:38
elharo
elharo reviewed Oct 3, 2019
View reviewed changes
@rahulKQL rahulKQL requested a review from elharo October 3, 2019 15:04
igorbernstein2
igorbernstein2 approved these changes Oct 8, 2019
View reviewed changes
Copy link
@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorbernstein2 igorbernstein2 dismissed kolea2’s stale review October 8, 2019 19:43

I think all comments have been addressed. If anything else needs to be updated, we can do another PR

@igorbernstein2 igorbernstein2 merged commit 7c0e837 into googleapis:master Oct 8, 2019
@chingor13 chingor13 mentioned this pull request Oct 9, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 Awaiting requested review from kolea2

@elharo elharo Awaiting requested review from elharo

1 more reviewer

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rahulKQL @elharo @igorbernstein2 @kolea2 @googlebot
0