8000 Translate: fix sample output by munkhuushmgl · Pull Request #6197 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Translate: fix sample output #6197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 3 commits into from
Aug 29, 2019
Merged

Translate: fix sample output #6197

chingor13 merged 3 commits into from
Aug 29, 2019

Conversation

@munkhuushmgl
Copy link
8000
Contributor
@munkhuushmgl munkhuushmgl commented Aug 29, 2019

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2019
@beccasaurus
Copy link
beccasaurus commented Aug 29, 2019

I don't have rights to add reviewers. Ping @nnegrey? :)

@nnegrey
Copy link
Contributor
nnegrey commented Aug 29, 2019

@chingor13 (neither do I)

@nnegrey
Copy link
Contributor
nnegrey commented Aug 29, 2019

or @kolea2

nnegrey
nnegrey approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor
@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13 chingor13 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 29, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2019
@chingor13 chingor13 changed the title small bug Translate: fix sample output Aug 29, 2019
@chingor13 chingor13 merged commit 8e93e85 into googleapis:master Aug 29, 2019
@chingor13 chingor13 mentioned this pull request Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

+1 more reviewer

@nnegrey nnegrey nnegrey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@munkhuushmgl @beccasaurus @nnegrey @chingor13 @googlebot @yoshi-kokoro
0