8000 Bigtable: Added deleteForcedAppProfile InstanceAdmin operation by rahulKQL · Pull Request #6193 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Bigtable: Added deleteForcedAppProfile InstanceAdmin operation #6193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rahulKQL merged 1 commit into from
Aug 30, 2019
Merged

Bigtable: Added deleteForcedAppProfile InstanceAdmin operation #6193

rahulKQL merged 1 commit into from
Aug 30, 2019

Conversation

@rahulKQL
Copy link
@rahulKQL rahulKQL commented Aug 29, 2019
  • added deleteAppProfile{Async}() BigtableInstanceAdminClient to adapt to ignore warnings/forced appProfile deletion.
  • updated test case.

discussed here.

@rahulKQL
Added deleteForcedAppProfile InstanceAdmin operation
16a0555 
 - added deleteAppProfile[Async]() BigtableInstanceAdminClient to adapt to ignore warnings/forced appProfile deletion.
 - updated test case.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2019
igorbernstein2
igorbernstein2 approved these changes Aug 29, 2019
View reviewed changes
Copy link
@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rahulKQL rahulKQL merged commit 3cede9f into googleapis:master Aug 30, 2019
@chingor13 chingor13 mentioned this pull request Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 Awaiting requested review from kolea2

1 more reviewer

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rahulKQL @igorbernstein2 @googlebot
0