8000 Unflake SpannerGaxRetryTest by kolea2 · Pull Request #6184 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Unflake SpannerGaxRetryTest #6184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olavloite merged 1 commit into from
Aug 28, 2019
Merged

Unflake SpannerGaxRetryTest #6184

olavloite merged 1 commit into from
Aug 28, 2019

Conversation

@kolea2
Copy link
Contributor
@kolea2 kolea2 commented Aug 27, 2019

Reverting HUNDRED_MS to ONE_SECOND

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019
@codecov
Copy link
codecov bot commented Aug 27, 2019 •
edited
Loading

Codecov Report

Merging #6184 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6184      +/-   ##
============================================
- Coverage      47.5%   47.22%   -0.29%     
  Complexity    27432    27432              
============================================
  Files          2523     2523              
  Lines        274592   274451     -141     
  Branches      31401    30578     -823     
============================================
- Hits         130439   129597     -842     
+ Misses       134520   134432      -88     
- Partials       9633    10422     +789
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 48.8% <0%> (-6.45%) 143% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 47.9% <0%> (-5.99%) 43% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.63% <0%> (-5.84%) 35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java 48.1% <0%> (-5.7%) 39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java 48.81% <0%> (-5.69%) 51% <0%> (ø)
... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48ee81...022d6d6. Read the comment docs.

olavloite
olavloite approved these changes Aug 28, 2019
View reviewed changes
Copy link
@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good idea.

@olavloite olavloite merged commit de9eea8 into googleapis:master Aug 28, 2019
@kolea2 kolea2 deleted the spanner-gaxtest branch August 28, 2019 14:00
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@olavloite olavloite olavloite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolea2 @olavloite @googlebot
0