8000 Spanner: Remove tracing implementation from tests by olavloite · Pull Request #6176 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Spanner: Remove tracing implementation from tests #6176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skuruppu merged 1 commit into from
Aug 28, 2019
Merged

Spanner: Remove tracing implementation from tests #6176

skuruppu merged 1 commit into from
Aug 28, 2019

Conversation

@olavloite
Copy link
@olavloite olavloite commented Aug 27, 2019

OpenCensus added a finalizer that checks that all spans have been closed in the latest version. Using tracer implementations in combination with tests therefore spams the logs with a lot of warnings, as much test code is deliberately only executing part of for example a transaction.

@olavloite olavloite requested review from kolea2 and skuruppu August 27, 2019 13:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019
@olavloite
remove tracing implementation from tests
3ed7325 
OpenCensus added a finalizer that checks that all spans have
been closed in the latest version. Using tracer implementations
in combination with tests therefore spams the logs with a lot
of warnings, as much test code is deliberately only executing
part of for example a transaction.
@olavloite olavloite force-pushed the spanner-remove-tracing-from-tests branch from 3cb3691 to 3ed7325 Compare August 27, 2019 15:38
@codecov
Copy link
codecov bot commented Aug 27, 2019

Codecov Report

Merging #6176 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6176      +/-   ##
============================================
- Coverage      47.5%   47.14%   -0.37%     
+ Complexity    27432    25967    -1465     
============================================
  Files          2523     2523              
  Lines        274592   269316    -5276     
  Branches      31401    31199     -202     
============================================
- Hits         130439   126960    -3479     
+ Misses       134520   133657     -863     
+ Partials       9633     8699     -934
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java 63.41% <0%> (-2.5%) 12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java 55.88% <0%> (-2.46%) 9% <0%> (-2%)
...oogle/cloud/language/v1/LanguageServiceClient.java 79.16% <0%> (-2.32%) 26% <0%> (-9%)
... and 640 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48ee81...3ed7325. Read the comment docs.

@skuruppu skuruppu merged commit bcf4068 into googleapis:master Aug 28, 2019
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 Awaiting requested review from kolea2

1 more reviewer

@skuruppu skuruppu skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite @skuruppu @googlebot
0