spanner-jdbc: Don't call getExitingExecutorService in StatementExecutor #6170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThreadPoolExecutor to be GC'd when StatementExecutor is finished (getExitingExecutorService will keep it around until application exits). Keeping all ThreadPoolExecutors around is effectively a memory leak, and can lead to substantial memory increase if an app uses many StatementExecutors.
|
Good spot. The method was called to ensure that the executor would use a daemon |
|
The failed build on Windows Java 8 is unrelated to this PR, and is fixed by #6174. |
olavloite
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
LGTM. The original reason for calling getExitingExecutorService was to ensure it used daemon threads. That is not needed as it is handed a ThreadFactory that already does that.
|
@kolea2 Could you have a quick look as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove call to getExitingExecutorService when we create a new
ThreadPoolExecutor in spanner-jdbc's StatementExecutor.
Calling getExitingExecutorService converts the ThreadPoolExecutor into an
ExecutorService that exits when the application is complete i.e. we keep
around the ThreadPoolExecutor and won't GC it. Given that we allocate a new
ThreadPoolExecutors for every StatementExecutor, this is effectively a
memory leak since the ThreadPoolExecutors is kept around after
StatementExecutor is GC'd and the ThreadPoolExecutor has been shutdown. It
can lead to substantial memory usage if an app uses many
StatementExecutors.