Update BigTable conformance tests (#5901) #6166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor ReadRowsMergingAcceptanceTest to use the generated Java Protobuf classes from the google-cloud-conformance-test module. The format read from is still json. * Update to use the latest revision of the conformance-tests data.
igorbernstein2
suggested changes
Aug 26, 2019
There was a problem hiding this comment.
Thanks for getting all of the clients aligned!
...test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #6166 +/- ##
=========================================
Coverage ? 46.82%
Complexity ? 25936
=========================================
Files ? 2524
Lines ? 269245
Branches ? 30390
=========================================
Hits ? 126064
Misses ? 133694
Partials ? 9487Continue to review full report at Codecov.
|
igorbernstein2
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
LGTM! thanks again for normalizing expectations across clients!
Contributor
Author
|
Failing test in the windows build is from the flaky spanner testsuite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf classes from the google-cloud-conformance-test module.
The format read from is still json.