Spanner: Fix potential session leak when BeginTransaction would throw an error #6165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f07de1f to
80809d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #6165 +/- ##
=========================================
Coverage ? 47.49%
Complexity ? 27432
=========================================
Files ? 2524
Lines ? 274672
Branches ? 31414
=========================================
Hits ? 130445
Misses ? 134594
Partials ? 9633Continue to review full report at Codecov.
|
The session that caused an error should be released back into the pool before an error is returned to the caller in order to trigger a new prepare of a session. The prepare will be triggered because the pool will see the caller that is still waiting for a write session as a readWriteWaiter.
skuruppu
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a non-retryable error occurred during the BeginTransaction rpc, a session would leak from the pool.
Fixes #6164