8000 Spanner: Simplify and unflake SpannerGaxRetryTest by olavloite · Pull Request #6163 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Spanner: Simplify and unflake SpannerGaxRetryTest #6163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olavloite merged 3 commits into from
Aug 27, 2019
Merged

Spanner: Simplify and unflake SpannerGaxRetryTest #6163

olavloite merged 3 commits into from
Aug 27, 2019

Conversation

@olavloite
Copy link
@olavloite olavloite commented Aug 26, 2019

@olavloite olavloite requested review from kolea2 and skuruppu August 26, 2019 15:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2019
@olavloite olavloite force-pushed the spanner-unflake-gax-retry-test branch from 2877bf4 to 204b1e4 Compare August 26, 2019 16:28
@codecov
Copy link
codecov bot commented Aug 26, 2019 •
edited
Loading

Codecov Report

Merging #6163 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph


8000
@@             Coverage Diff              @@
##             master    #6163      +/-   ##
============================================
+ Coverage     47.45%   47.49%   +0.03%     
- Complexity    27372    27432      +60     
============================================
  Files          2524     2524              
  Lines        274664   274672       +8     
  Branches      31414    31414              
============================================
+ Hits         130347   130445      +98     
+ Misses       134676   134594      -82     
+ Partials       9641     9633       -8
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/cloud/storage/Storage.java 79.72% <0%> (ø) 0% <0%> (ø) ⬇️
...le/cloud/compute/v1/ProjectGlobalSnapshotName.java 56.36% <0%> (ø) 8% <0%> (ø) ⬇️
...cloud/compute/v1/ProjectZoneInstanceGroupName.java 57.14% <0%> (ø) 8% <0%> (ø) ⬇️
...1/ProjectZoneNetworkEndpointGroupResourceName.java 57.14% <0%> (ø) 8% <0%> (ø) ⬇️
...ompute/v1/ProjectRegionSubnetworkResourceName.java 57.14% <0%> (ø) 8% <0%> (ø) ⬇️
...ud/compute/v1/ProjectGlobalSecurityPolicyName.java 56.36% <0%> (ø) 8% <0%> (ø) ⬇️
...ud/compute/v1/ProjectGlobalTargetTcpProxyName.java 56.36% <0%> (ø) 8% <0%> (ø) ⬇️
...oud/compute/v1/ProjectGlobalBackendBucketName.java 56.36% <0%> (ø) 8% <0%> (ø) ⬇️
.../cloud/compute/v1/ProjectRegionTargetPoolName.java 57.14% <0%> (ø) 8% <0%> (ø) ⬇️
...d/compute/v1/ProjectGlobalTargetHttpProxyName.java 56.36% <0%> (ø) 8% <0%> (ø) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afa233...a3c4966. Read the comment docs.

@olavloite olavloite merged commit f48ee81 into googleapis:master Aug 27, 2019
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skuruppu skuruppu Awaiting requested review from skuruppu

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite @kolea2 @googlebot
0