8000 Storage: Fix PolicyHelper.convertFromApiPolicy fails if no bindings exist by athakor · Pull Request #6160 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Storage: Fix PolicyHelper.convertFromApiPolicy fails if no bindings exist #6160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JesseLovelace merged 3 commits into from
Sep 30, 2019
Merged

Storage: Fix PolicyHelper.convertFromApiPolicy fails if no bindings exist #6160

JesseLovelace merged 3 commits into from
Sep 30, 2019

Conversation

@athakor
Copy link
Contributor
@athakor athakor commented Aug 26, 2019

Fixes #6082

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2019
@codecov
Copy link
codecov bot commented Aug 26, 2019

Codecov Report

Merging #6160 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6160      +/-   ##
============================================
- Coverage     47.38%   47.38%   -0.01%     
- Complexity    27182    27183       +1     
============================================
  Files          2524     2524              
  Lines        274612   274615       +3     
  Branches      31383    31384       +1     
============================================
+ Hits         130125   130126       +1     
- Misses       134874   134875       +1     
- Partials       9613     9614       +1
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/storage/PolicyHelper.java 95.23% <85.71%> (-4.77%) 7 <0> (+1)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 89.11% <0%> (-0.35%) 40% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2f465...ae161f9. Read the comment docs.

@athakor athakor requested review from chingor13 and removed request for frankyn September 12, 2019 13:47
@athakor
Copy link
Contributor Author
athakor commented Sep 12, 2019

@chingor13 PTAL

@JesseLovelace JesseLovelace merged commit 2a648c8 into googleapis:master Sep 30, 2019
@chingor13 chingor13 mentioned this pull request Oct 2, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

1 more reviewer

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Storage: PolicyHelper.convertFromApiPolicy fails if no bindings exist

3 participants

@athakor @JesseLovelace @googlebot
0