8000 spanner-jdbc: Add tests for JdbcStatement by olavloite · Pull Request #6158 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

spanner-jdbc: Add tests for JdbcStatement #6158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolea2 merged 2 commits into from
Aug 26, 2019
Merged

spanner-jdbc: Add tests for JdbcStatement #6158

kolea2 merged 2 commits into from
Aug 26, 2019

Conversation

@olavloite
Copy link
@olavloite olavloite commented Aug 25, 2019

Adds additional tests for JdbcStatement. Also fixes an issue that executing statements and requesting generated keys to be returned should throw a SQLFeatureNotSupportedException.

@olavloite olavloite requested review from kolea2 and skuruppu August 25, 2019 18:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2019
@codecov
Copy link
codecov bot commented Aug 25, 2019 •
edited
Loading

Codecov Report

Merging #6158 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6158      +/-   ##
============================================
+ Coverage     47.38%   47.39%   +<.01%     
- Complexity    27182    27192      +10     
============================================
  Files          2524     2524              
  Lines        274612   274614       +2     
  Branches      31383    31385       +2     
============================================
+ Hits         130125   130150      +25     
+ Misses       134874   134851      -23     
  Partials       9613     9613
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/spanner/jdbc/JdbcConnection.java 30.37% <ø> (ø) 17 <0> (ø) ⬇️
...a/com/google/cloud/spanner/jdbc/JdbcStatement.java 67.74% <100%> (+16.1%) 38 <0> (+10) ⬆️
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 89.11% <0%> (-0.35%) 40% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2f465...46165ae. Read the comment docs.

@kolea2 kolea2 merged commit 822290e into googleapis:master Aug 26, 2019
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skuruppu skuruppu Awaiting requested review from skuruppu

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite @kolea2 @googlebot
0