8000 spanner-jdbc: Add tests for JdbcConnection by olavloite · Pull Request #6157 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

spanner-jdbc: Add tests for JdbcConnection #6157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olavloite merged 2 commits into from
Aug 27, 2019
Merged

spanner-jdbc: Add tests for JdbcConnection #6157

olavloite merged 2 commits into from
Aug 27, 2019

Conversation

@olavloite
Copy link
@olavloite olavloite commented Aug 25, 2019

Adds additional tests for JdbcConnection. Also fixes a small issue in JdbcConnection that caused the method isValid(int) to throw an exception when called on a closed connection, instead of returning false as it should have.

@olavloite olavloite requested review from kolea2 and skuruppu August 25, 2019 17:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2019
@kolea2
Copy link
Contributor
kolea2 commented Aug 26, 2019

LGTM just needs a rebase

@olavloite olavloite force-pushed the spanner-jdbc-add-tests-for-connection branch from 9b0f79f to f610444 Compare August 26, 2019 15:49
@codecov
Copy link
codecov bot commented Aug 26, 2019 •
edited
Loading

Codecov Report

Merging #6157 into master will increase coverage by 0.05%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6157      +/-   ##
============================================
+ Coverage     47.41%   47.47%   +0.05%     
- Complexity    27258    27402     +144     
============================================
  Files          2524     2524              
  Lines        274663   274664       +1     
  Branches      31414    31414              
============================================
+ Hits         130239   130402     +163     
+ Misses       134783   134621     -162     
  Partials       9641     9641
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/spanner/jdbc/JdbcConnection.java 56.96% <75%> (+26.58%) 41 <0> (+24) ⬆️
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 89.11% <0%> (-0.35%) 40% <0%> (ø)
...gle/cloud/spanner/jdbc/AbstractJdbcConnection.java 65.27% <0%> (+1.38%) 21% <0%> (+1%) ⬆️
...ogle/cloud/spanner/jdbc/AbstractJdbcStatement.java 55.26% <0%> (+5.26%) 29% <0%> (+5%) ⬆️
...ogle/cloud/spanner/jdbc/AbstractJdbcResultSet.java 100% <0%> (+95.79%) 117% <0%> (+114%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfc925...f610444. Read the comment docs.

@olavloite olavloite merged commit b188bf3 into googleapis:master Aug 27, 2019
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skuruppu skuruppu Awaiting requested review from skuruppu

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite @kolea2 @googlebot
0