8000 Spanner: Re-enable test depending on gax 1.47 by olavloite · Pull Request #6152 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Spanner: Re-enable test depending on gax 1.47 #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kolea2 merged 1 commit into from
Aug 26, 2019
Merged

Spanner: Re-enable test depending on gax 1.47 #6152

kolea2 merged 1 commit into from
Aug 26, 2019

Conversation

@olavloite
Copy link
@olavloite olavloite commented Aug 24, 2019

Re-enables a test case that depended on gax version 1.47 or higher.

@olavloite olavloite requested review from athakor and skuruppu August 24, 2019 17:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2019
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2019
@codecov
Copy link
codecov bot commented Aug 25, 2019 •
edited
Loading

Codecov Report

Merging #6152 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6152      +/-   ##
============================================
+ Coverage     47.01%   47.38%   +0.36%     
- Complexity    25717    27182    +1465     
============================================
  Files          2524     2524              
  Lines        269337   274612    +5275     
  Branches      31190    31383     +193     
============================================
+ Hits         126641   130125    +3484     
- Misses       134018   134874     +856     
- Partials       8678     9613     +935
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 55.24% <0%> (-7.81%) 143% <0%> (+35%)
...onitoring/v3/NotificationChannelServiceClient.java 64.49% <0%> (-7.13%) 43% <0%> (+10%)
...ava/com/google/cloud/compute/v1/ProjectClient.java 57.07% <0%> (-6.99%) 55% <0%> (+13%)
.../com/google/cloud/compute/v1/TargetPoolClient.java 57.73% <0%> (-6.98%) 47% <0%> (+11%)
...va/com/google/cloud/compute/v1/SnapshotClient.java 55.73% <0%> (-6.88%) 31% <0%> (+7%)
...oogle/cloud/kms/v1/KeyManagementServiceClient.java 62.88% <0%> (-6.84%) 103% <0%> (+25%)
...com/google/cloud/compute/v1/ReservationClient.java 59.14% <0%> (-6.83%) 39% <0%> (+9%)
...a/com/google/cloud/compute/v1/NodeGroupClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
.../com/google/cloud/compute/v1/SubnetworkClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
...d/compute/v1/RegionInstanceGroupManagerClient.java 54.5% <0%> (-6.79%) 51% <0%> (+12%)
... and 639 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2f465...f15768b. Read the comment docs.

@kolea2 kolea2 merged commit 797ff43 into googleapis:master Aug 26, 2019
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skuruppu skuruppu Awaiting requested review from skuruppu

@athakor athakor Awaiting requested review from athakor

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olavloite @kolea2 @googlebot @yoshi-kokoro
0