8000 Spanner: Print stack trace in case of test case flake by olavloite · Pull Request #6151 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Spanner: Print stack trace in case of test case flake #6151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skuruppu merged 1 commit into from
Aug 28, 2019
Merged

Spanner: Print stack trace in case of test case flake #6151

skuruppu merged 1 commit into from
Aug 28, 2019

Conversation

@olavloite
Copy link
@olavloite olavloite commented Aug 24, 2019

The test case com.google.cloud.spanner.spi.v1.GapicSpannerRpcTest.testCloseAllThreadsWhenClosingSpanner sometimes fails with no further information. This adds a stack trace of the hanging thread when it happens.
An example of a flaky failed build here: https://source.cloud.google.com/results/invocations/b472c233-c011-45c0-8b96-650ff6284bec/targets/cloud-devrel%2Fclient-libraries%2Fjava%2Fgoogle-cloud-java%2Fpresubmit%2Fjava8-win/log

@olavloite olavloite requested review from kolea2 and skuruppu August 24, 2019 17:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2019
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2019
@skuruppu skuruppu merged commit 62405dd into googleapis:master Aug 28, 2019
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 Awaiting requested review from kolea2

1 more reviewer

@skuruppu skuruppu skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olavloite @skuruppu @googlebot @yoshi-kokoro
0