10BC0 Bigtable: update pom.xml to fail loudly when an invalid profile id is passed by igorbernstein2 · Pull Request #6141 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Bigtable: update pom.xml to fail loudly when an invalid profile id is passed #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Aug 26, 2019
Merged

Bigtable: update pom.xml to fail loudly when an invalid profile id is passed #6141

chingor13 merged 1 commit into from
Aug 26, 2019

Conversation

@igorbernstein2
Copy link
@igorbernstein2 igorbernstein2 commented Aug 22, 2019

Bigtable uses maven profiles for running integration tests. If the user mistypes the profile id, the test profile isn't activated and the build succeeds, giving a false positive result. This PR will just fail the build

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

@igorbernstein2
Bigtable: update pom.xml to fail loudly when an invalid profile id is…
91ef59f 
… passed

Bigtable uses maven profiles for running integration tests. If the user mistypes the profile id, the test profile isn't activated and the build succeeds, giving a false positive result. This PR will just fail the build
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
@igorbernstein2 igorbernstein2 added api: bigtable Issues related to the Bigtable API. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 22, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
@chingor13 chingor13 self-assigned this Aug 26, 2019
@codecov
Copy link
codecov bot commented Aug 26, 2019 •
edited
Loading

Codecov Report

Merging #6141 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6141      +/-   ##
============================================
+ Coverage     47.38%   47.63%   +0.24%     
- Complexity    27197    27708     +511     
============================================
  Files          2523     2524       +1     
  Lines        274600   277456    +2856     
  Branches      31378    31835     +457     
============================================
+ Hits         130124   132157    +2033     
- Misses       134863   135815     +952     
+ Partials       9613     9484     -129
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/firestore/DocumentSnapshot.java 85.16% <0%> (-0.56%) 77% <0%> (+22%)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 84.8% <0%> (-0.07%) 221% <0%> (+76%)
...main/java/com/google/cloud/firestore/Internal.java 0% <0%> (ø) 0% <0%> (?)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 89.45% <0%> (+0.34%) 40% <0%> (ø) ⬇️
...n/java/com/google/cloud/spanner/jdbc/JdbcBlob.java 84.32% <0%> (+0.74%) 37% <0%> (+1%) ⬆️
...n/java/com/google/cloud/spanner/jdbc/JdbcClob.java 75.86% <0%> (+1.14%) 30% <0%> (+1%) ⬆️
...ud/bigtable/admin/v2/BigtableTableAdminClient.java 81.31% <0%> (+1.31%) 46% <0%> (+19%) ⬆️
...pute/v1/ProjectRegionInstanceGroupManagerName.java 62% <0%> (+1.7%) 10% <0%> (+2%) ⬆️
...te/v1/ProjectRegionInterconnectAttachmentName.java 62% <0%> (+1.7%) 10% <0%> (+2%) ⬆️
.../compute/v1/ProjectRegionTargetVpnGatewayName.java 61.61% <0%> (+1.91%) 10% <0%> (+2%) ⬆️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e97c3...91ef59f. Read the comment docs.

@chingor13 chingor13 merged commit a7063d2 into googleapis:master Aug 26, 2019
@igorbernstein2 igorbernstein2 deleted the enforce-valid-profile branch August 26, 2019 17:38
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

@kolea2 kolea2 Awaiting requested review from kolea2

Assignees

@chingor13 chingor13

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2 @chingor13 @googlebot
0