8000 Small refactoring to signUrl code. by houglum · Pull Request #6078 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Small refactoring to signUrl code. #6078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JesseLovelace merged 2 commits into from
Aug 26, 2019
Merged

Small refactoring to signUrl code. #6078

JesseLovelace merged 2 commits into from
Aug 26, 2019

Conversation

@houglum
Copy link
@houglum houglum commented Aug 14, 2019

This commit attempts to refactor some of the functionality in signUrl
such that it's easier to follow and will be easier to add functionality
for generating virtual hosted-style signed URLs. The branch containing
future changes is shown below; this commit is mostly trying to separate
refactoring from new functionality being added:
https://github.com/houglum/google-cloud-java/compare/6e0f6ef..b52205b

This commit also contains a couple of small doc tweaks.

@houglum
Small refactoring to signUrl code.
096b782 
This commit attempts to refactor some of the functionality in signUrl
such that it's easier to follow and will be easier to add functionality
for generating virtual hosted-style signed URLs. The branch containing
the changes is shown below; this commit is mostly trying to separate
refactoring from new functionality being added:
https://github.com/houglum/google-cloud-java/compare/6e0f6ef..b52205b

This commit also contains a couple of small doc tweaks.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2019
@houglum
Copy link
Author
houglum commented Aug 14, 2019

@frankyn FYI, this is to help facilitate adding the signed URL functionality we talked about last week

@frankyn frankyn requested a review from JesseLovelace August 14, 2019 21:13
@codecov
Copy link
codecov bot commented Aug 16, 2019 •
edited
Loading

Codecov Report

Merging #6078 into master will increase coverage by 0.65%.
The diff coverage is 96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6078      +/-   ##
============================================
+ Coverage     46.73%   47.39%   +0.65%     
- Complexity    25715    27183    +1468     
============================================
  Files          2523     2523              
  Lines        269162   274588    +5426     
  Branches      30364    31380    +1016     
============================================
+ Hits         125789   130131    +4342     
- Misses       133910   134850     +940     
- Partials       9463     9607     +144
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/cloud/storage/Storage.java 79.72% <100%> (ø) 0 <0> (ø) ⬇️
...ain/java/com/google/cloud/storage/StorageImpl.java 78.37% <95.65%> (+0.63%) 100 <0> (+2) ⬆️
...re/src/main/java/com/google/cloud/BaseService.java 55.55% <0%> (-6.95%) 2% <0%> (ø)
...re/src/main/java/com/google/cloud/RetryHelper.java 50% <0%> (-3.85%) 2% <0%> (ø)
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...m/google/cloud/tasks/v2beta3/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
...va/com/google/cloud/tasks/v2/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
...m/google/cloud/tasks/v2beta2/CloudTasksClient.java 57.14% <0%> (-2.39%) 79% <0%> (+19%)
...oogle/cloud/firestore/v1/FirestoreAdminClient.java 59.84% <0%> (-2.23%) 38% <0%> (+8%)
.../cloud/scheduler/v1beta1/CloudSchedulerClient.java 55% <0%> (-2.15%) 35% <0%> (+8%)
... and 673 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0d5ce...ae8e312. Read the comment docs.

@houglum
Copy link
Author
houglum commented Aug 16, 2019

Only presubmit failure was from the linter; I ran mvn com.coveo:fmt-maven-plugin:format and sent a follow-up commit.

@houglum
Copy link
Author
houglum commented Aug 26, 2019

@JesseLovelace friendly ping

I've got a couple more PRs queued up after this one (those are more substantial and introduce additional functionality), so reviewing this would unblock me :)

@JesseLovelace JesseLovelace merged commit e2fc2c3 into googleapis:master Aug 26, 2019
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JesseLovelace JesseLovelace

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@houglum @JesseLovelace @googlebot
0