10BC0 Update enum Regions.java with latest regions by SeventhOfNine · Pull Request #5745 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Update enum Regions.java with latest regions #5745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Jul 15, 2019
Merged

Update enum Regions.java with latest regions #5745

chingor13 merged 1 commit into from
Jul 15, 2019

Conversation

@SeventhOfNine
Copy link
Contributor
@SeventhOfNine SeventhOfNine commented Jul 15, 2019

Add latest regions:

  • asia-northeast2
  • europe-west6

Fixes ##5744

@SeventhOfNine
Update Regions.java with latest regions
c39f7a1 
Add latest regions:
- asia-northeast2
- europe-west6
@googlebot
Copy link
googlebot commented Jul 15, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 15, 2019
@SeventhOfNine
Copy link
Contributor Author
SeventhOfNine commented Jul 15, 2019

I signed it!

@googlebot
Copy link
googlebot commented Jul 15, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 15, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2019
@chingor13 chingor13 self-assigned this Jul 15, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2019
@codecov
Copy link
codecov bot commented Jul 15, 2019

Codecov Report

Merging #5745 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5745      +/-   ##
============================================
- Coverage     46.91%   46.71%   -0.21%     
+ Complexity    25078    23629    -1449     
============================================
  Files          2389     2389              
  Lines        259743   254611    -5132     
  Branches      29388    29255     -133     
============================================
- Hits         121871   118933    -2938     
+ Misses       128487   127626     -861     
+ Partials       9385     8052    -1333
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/cloud/compute/Regions.java 93.75% <100%> (+0.41%) 4 <0> (ø) ⬇️
...igtable/gaxx/retrying/ApiResultRetryAlgorithm.java 30.76% <0%> (ø) 6% <0%> (ø) ⬇️
...gle/cloud/compute/deprecated/ForwardingRuleId.java 75% <0%> (ø) 5% <0%> (ø) ⬇️
...com/google/cloud/compute/deprecated/AddressId.java 75% <0%> (ø) 5% <0%> (ø) ⬇️
...m/google/cloud/compute/deprecated/OperationId.java 76.92% <0%> (ø) 5% <0%> (ø) ⬇️
.../bigtable/admin/v2/BigtableTableAdminSettings.java 71.73% <0%> (ø) 7% <0%> (ø) ⬇️
...mpute/deprecated/StandardNetworkConfiguration.java 78.57% <0%> (ø) 10% <0%> (ø) ⬇️
...com/google/cloud/bigquery/GoogleSheetsOptions.java 73.07% <0%> (ø) 8% <0%> (ø) ⬇️
...cloud/compute/deprecated/NetworkConfiguration.java 81.25% <0%> (ø) 7% <0%> (ø) ⬇️
...va/com/google/cloud/storage/spi/v1/StorageRpc.java 62.85% <0%> (ø) 0% <0%> (ø) ⬇️
... and 1808 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7870fe...c39f7a1. Read the comment docs.

@chingor13 chingor13 merged commit ccfe9b4 into googleapis:master Jul 15, 2019
@chingor13 chingor13 mentioned this pull request Jul 16, 2019
Closed
@SeventhOfNine SeventhOfNine deleted the patch-1 branch July 16, 2019 20:30
@JesseLovelace JesseLovelace mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SeventhOfNine @googlebot @chingor13 @yoshi-kokoro
0