8000 Os-login : Cleanup dependency by athakor · Pull Request #5665 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Os-login : Cleanup dependency #5665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 3 commits into from
Jul 3, 2019
Merged

Os-login : Cleanup dependency #5665

sduskis merged 3 commits into from
Jul 3, 2019

Conversation

@athakor
Copy link
Contributor
@athakor athakor commented Jul 3, 2019

towards #4383

@athakor athakor requested a review from a team as a code owner July 3, 2019 11:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 3, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@codecov
Copy link
codecov bot commented Jul 3, 2019

Codecov Report

Merging #5665 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #5665     +/-   ##
===========================================
- Coverage     46.71%   46.42%   -0.3%     
+ Complexity    24644    24629     -15     
===========================================
  Files          2351     2351             
  Lines        256127   256009    -118     
  Branches      29320    28536    -784     
===========================================
- Hits         119648   118850    -798     
+ Misses       127559   127479     -80     
- Partials       8920     9680    +760
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java 48.95% <0%> (-6.46%) 139% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.63% <0%> (-5.84%) 35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 48.92% <0%> (-5.76%) 35% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java 48.1% <0%> (-5.7%) 39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java 48.81% <0%> (-5.69%) 51% <0%> (ø)
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1392cab...82e599e. Read the comment docs.

@sduskis sduskis merged commit 44420e8 into googleapis:master Jul 3, 2019
@kolea2 kolea2 mentioned this pull request Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@athakor @sduskis @googlebot @pmakani @yoshi-kokoro
0