10000 Add Tasks smoke test by chingor13 · Pull Request #5628 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@chingor13
Copy link
Contributor

This test is adapted from java-docs-samples.

@chingor13 chingor13 requested a review from a team as a code owner July 1, 2019 20:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2019
@codecov-io
Copy link
codecov-io commented Jul 1, 2019

Codecov Report

Merging #5628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5628   +/-   ##
=========================================
  Coverage     46.71%   46.71%           
  Complexity    24629    24629           
=========================================
  Files          2351     2351           
  Lines        256127   256127           
  Branches      29325    29325           
=========================================
  Hits         119648   119648           
  Misses       127559   127559           
  Partials       8920     8920

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b15d1...e6fdc64. Read the comment docs.


@Test
public void run() {
main(null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor - want to inline this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the existing format for the generated SmokeTests (example)

@chingor13 chingor13 merged commit 13928f8 into googleapis:master Jul 3, 2019
@chingor13 chingor13 deleted the tasks-smoke-test branch July 3, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0