8000 [Bigtable] Fixes Query#toProto state change effect by rahulKQL · Pull Request #5621 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

[Bigtable] Fixes Query#toProto state change effect #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Jul 1, 2019
Merged

[Bigtable] Fixes Query#toProto state change effect #5621

sduskis merged 1 commit into from
Jul 1, 2019

Conversation

@rahulKQL
8000 Copy link
@rahulKQL rahulKQL commented Jul 1, 2019

Fixes #5550

This change address the hashcode change problem of Query after calling Query#toProto.

@rahulKQL
Fixes Query#toProto state change effect
0f4aefe 
This change address the hashcode change problem of Query after calling toProto.
@rahulKQL rahulKQL requested a review from a team as a code owner July 1, 2019 13:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2019
@rahulKQL
Copy link
Author
rahulKQL commented Jul 1, 2019

@igorbernstein2, @sduskis Please have a look.

igorbernstein2
igorbernstein2 approved these changes Jul 1, 2019
View reviewed changes
Copy link
@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@igorbernstein2 igorbernstein2 added api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 1, 2019
@sduskis sduskis merged commit 9062789 into googleapis:master Jul 1, 2019
This was referenced Jul 2, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to use Bigtable Query object as cache key

5 participants

@rahulKQL @igorbernstein2 @sduskis @googlebot @yoshi-kokoro
0