E523 Bigtable: Update javadoc by cshaff0524 · Pull Request #5178 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Bigtable: Update javadoc #5178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorbernstein2 merged 2 commits into from
May 16, 2019
Merged

Bigtable: Update javadoc #5178

igorbernstein2 merged 2 commits into from
May 16, 2019

Conversation

@cshaff0524
Copy link
@cshaff0524 cshaff0524 commented May 13, 2019

Text-only edits to comments and error messages.

@cshaff0524 cshaff0524 requested a review from a team as a code owner May 13, 2019 19:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2019
igorbernstein2
igorbernstein2 approved these changes May 13, 2019
View reviewed changes
Copy link
@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning this up!

@igorbernstein2 igorbernstein2 added api: bigtable Issues related to the Bigtable API. type: docs Improvement to the documentation for an API. labels May 13, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@codecov
Copy link
codecov bot commented May 16, 2019 •
edited
Loading

Codecov Report

Merging #5178 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5178      +/-   ##
============================================
- Coverage      50.4%    50.4%   -0.01%     
  Complexity    23785    23785              
============================================
  Files          2251     2251              
  Lines        226791   226792       +1     
  Branches      24966    24966              
============================================
  Hits         114320   114320              
- Misses       103864   103865       +1     
  Partials       8607     8607
Impacted Files Coverage Δ Complexity Δ
...bigtable/admin/v2/BigtableInstanceAdminClient.java 97.09% <ø> (ø) 45 <0> (ø) ⬇️
.../bigtable/admin/v2/BigtableTableAdminSettings.java 71.73% <100%> (ø) 7 <0> (ø) ⬇️
...gtable/admin/v2/BigtableInstanceAdminSettings.java 100% <100%> (ø) 6 <0> (ø) ⬇️
...ud/bigtable/admin/v2/BigtableTableAdminClient.java 78.63% <100%> (ø) 27 <2> (ø) ⬇️
...acatalog/v1beta1/stub/DataCatalogStubSettings.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...m/google/cloud/tasks/v2beta3/CloudTasksClient.java 57.43% <0%> (ø) 67% <0%> (ø) ⬇️
...va/com/google/cloud/tasks/v2/CloudTasksClient.java 57.43% <0%> (ø) 67% <0%> (ø) ⬇️
...d/bigtable/admin/v2/models/CreateTableRequest.java 85.18% <0%> (ø) 8% <0%> (ø) ⬇️
...google/cloud/bigtable/admin/v2/models/GCRules.java 68.86% <0%> (ø) 16% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b78c52...3879cfe. Read the comment docs.

@cshaff0524
Copy link
Author
cshaff0524 commented May 16, 2019

I added a new commit after building this locally.

@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2019
@igorbernstein2 igorbernstein2 changed the title Minor edits to comments Bigtable: Update javadoc May 16, 2019
@igorbernstein2 igorbernstein2 merged commit 5b98115 into googleapis:master May 16, 2019
This was referenced May 22, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cshaff0524 @igorbernstein2 @chingor13 @googlebot @yoshi-kokoro
0