8000 P/S: moving all alarm setup into a single method by sduskis · Pull Request #5008 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

P/S: moving all alarm setup into a single method #5008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Apr 24, 2019
Merged

P/S: moving all alarm setup into a single method #5008

chingor13 merged 1 commit into from
Apr 24, 2019

Conversation

@sduskis
Copy link
Contributor
@sduskis sduskis commented Apr 24, 2019

Moving some alarm setup logic from publish() and some logic from setupDurationBasedPublishAlarm into a new method called setupAlarm

@sduskis
P/S: moving all alarm setup into a single method
7c5c5ac 
Moving some alarm setup logic from `publish()` and some logic from `setupDurationBasedPublishAlarm` into a new method called `setupAlarm`
@sduskis sduskis added the api: pubsub Issues related to the Pub/Sub API. label Apr 24, 2019
@sduskis sduskis requested a review from a team as a code owner April 24, 2019 18:11
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2019
@chingor13 chingor13 merged commit cef6cd0 into googleapis:master Apr 24, 2019
@chingor13 chingor13 mentioned this pull request Apr 24, 2019
Merged
@sduskis sduskis deleted the refactor_pubsub_0424_b branch April 24, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sduskis @chingor13 @googlebot
0