8000 Spanner: Refactor SpannerImpl - Remove dead code by olavloite · Pull Request #4988 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Spanner: Refactor SpannerImpl - Remove dead code #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Apr 22, 2019
Merged

Spanner: Refactor SpannerImpl - Remove dead code #4988

sduskis merged 1 commit into from
Apr 22, 2019

Conversation

@olavloite
Copy link
@olavloite olavloite commented Apr 20, 2019

Remove unused private code from SpannerImpl.

@olavloite olavloite requested a review from a team as a code owner April 20, 2019 06:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2019
@codecov
Copy link
codecov bot commented Apr 20, 2019 •
edited
Loading

Codecov Report

Merging #4988 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4988      +/-   ##
============================================
+ Coverage     49.98%   50.32%   +0.33%     
- Complexity    23668    23676       +8     
============================================
  Files          2238     2238              
  Lines        226007   226059      +52     
  Branches      24191    24955     +764     
============================================
+ Hits         112977   113754     +777     
- Misses       103690   103704      +14     
+ Partials       9340     8601     -739
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/com/google/cloud/BaseService.java 55.55% <0%> (-6.95%) 2% <0%> (ø)
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...va/com/google/cloud/http/HttpTransportOptions.java 56.33% <0%> (-1.64%) 10% <0%> (ø)
...ge/contrib/nio/CloudStorageFileSystemProvider.java 61.26% <0%> (-0.29%) 70% <0%> (ø)
...ain/java/com/google/cloud/logging/LoggingImpl.java 88.44% <0%> (-0.2%) 73% <0%> (ø)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 6.92% <0%> (-0.06%) 2% <0%> (ø)
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.82% <0%> (-0.01%) 1% <0%> (ø)
...restore/collection/ImmutableSortedMapIterator.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ud-core/src/main/java/com/google/cloud/Policy.java 96.61% <0%> (+0.02%) 12% <0%> (ø) ⬇️
...ain/java/com/google/cloud/storage/StorageImpl.java 86.19% <0%> (+0.04%) 103% <0%> (+5%) ⬆️
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bc33f...8c6dc19. Read the comment docs.

@sduskis sduskis merged commit 2eaa9f4 into googleapis:master Apr 22, 2019
@chingor13 chingor13 mentioned this pull request Apr 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olavloite @kolea2 @sduskis @googlebot
0