Changes the behavior of BigQueryImpl's getTableId #3873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now getTable of BigQueryImpl checks if the provided TableId has the project set. If yes, the set projectId is used, otherwise the projectId used when creating the BigQuery client will be used. The additional test checks this behavior by calling getTableId with an empty projectId.
JesseLovelace
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now getTable of BigQueryImpl checks if the provided TableId has the
project set. If yes, the set projectId is used, otherwise will default to the projectId used when creating the BigQuery client.
The additional test checks this behavior by calling getTableId with an
empty projectId.
Fixes #3808