8000 bump versions for release by neozwu · Pull Request #2449 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@neozwu
Copy link
Contributor
@neozwu neozwu commented Sep 18, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2017
@michaelbausor
Copy link
Contributor

LGTM, assuming that we are happy to make these changes part of a point release (I believe that is our current convention, but just wanted to check)

@neozwu neozwu force-pushed the bump-ver-for-release branch from 28bb731 to 2bbbc42 Compare September 18, 2017 22:00
@neozwu
Copy link
Contributor Author
neozwu commented Sep 18, 2017

@michaelbausor , after discussing with @vam-google , I pushed another commit to increment minor versions, since this change includes releasing a new Java lib. Do you think this makes sense ?

@michaelbausor
Copy link
Contributor

Yes, SGTM

Copy link
Contributor
@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neozwu neozwu merged commit b3cf618 into googleapis:master Sep 18, 2017
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0