8000 Converting Logging deserialized enum types to StringEnumValue by garrettjonesgoogle · Pull Request #1945 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Converting Logging deserialized enum types to StringEnumValue #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garrettjonesgoogle merged 1 commit into from
Apr 19, 2017
Merged

Converting Logging deserialized enum types to StringEnumValue #1945

garrettjonesgoogle merged 1 commit into from
Apr 19, 2017

Conversation

@garrettjonesgoogle
Copy link
Member
@garrettjonesgoogle garrettjonesgoogle commented Apr 19, 2017

There was only one for logging.

Fixes #1832 .

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2017
@michaelbausor
Copy link
Contributor
michaelbausor commented Apr 19, 2017

LGTM once tests pass

@coveralls
Copy link
coveralls commented Apr 19, 2017

Coverage Status

Coverage decreased (-0.003%) to 80.84% when pulling 16dcaa1 on garrettjonesgoogle:alt into 2fd93d9 on GoogleCloudPlatform:master.

96AC
@garrettjonesgoogle garrettjonesgoogle merged commit ff8376e into googleapis:master Apr 19, 2017
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@gcf-owl-bot @JoeWang1127
chore: update ignore paths in renovate config (#1945) (#1568)
edd828b 
* chore: update ignore paths in renovate config (#1945)

Source-Link: googleapis/synthtool@571a091
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81c3ec554428c8ff6c92f0d58668b7ef52265d053a82284c97a326745e786949

* change version

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Joe Wang <joewa@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelbausor michaelbausor Awaiting requested review from michaelbausor

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@garrettjonesgoogle @michaelbausor @coveralls @googlebot
0