8000 use new PartitionKey implementation by pongad · Pull Request #1841 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

use new PartitionKey implementation #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrettjonesgoogle merged 1 commit into from
Mar 31, 2017
Merged

use new PartitionKey implementation #1841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/LoggingSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import com.google.api.MonitoredResourceDescriptor;
import com.google.api.gax.batching.BatchingSettings;
import com.google.api.gax.batching.PartitionKey;
import com.google.api.gax.batching.RequestBuilder;
import com.google.api.gax.core.FlowControlSettings;
import com.google.api.gax.core.FlowController.LimitExceededBehavior;
Expand Down Expand Up @@ -399,13 +400,9 @@ public ListLogsPagedResponse createPagedListResponse(
WRITE_LOG_ENTRIES_BATCHING_DESC =
new BatchingDescriptor<WriteLogEntriesRequest, WriteLogEntriesResponse>() {
@Override
public String getBatchPartitionKey(WriteLogEntriesRequest request) {
return request.getLogName()
+ "|"
+ request.getResource()
+ "|"
+ request.getLabels()
+ "|";
public PartitionKey getBatchPartitionKey(WriteLogEntriesRequest request) {
return new PartitionKey(
request.getLogName(), request.getResource(), request.getLabels());
}

@Override
Expand Down
5 changes: 3 additions & 2 deletions google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/TopicAdminSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import static com.google.cloud.pubsub.spi.v1.PagedResponseWrappers.ListTopicsPagedResponse;

import com.google.api.gax.batching.BatchingSettings;
import com.google.api.gax.batching.PartitionKey;
import com.google.api.gax.batching.RequestBuilder;
import com.google.api.gax.core.FlowControlSettings;
import com.google.api.gax.core.FlowController.LimitExceededBehavior;
Expand Down Expand Up @@ -371,8 +372,8 @@ public ListTopicSubscriptionsPagedResponse createPagedListResponse(
private static final BatchingDescriptor<PublishRequest, PublishResponse> PUBLISH_BATCHING_DESC =
new BatchingDescriptor<PublishRequest, PublishResponse>() {
@Override
public String getBatchPartitionKey(PublishRequest request) {
return request.getTopic() + "|";
public PartitionKey getBatchPartitionKey(PublishRequest request) {
return new PartitionKey(request.getTopic());
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
<github.global.server>github</github.global.server>
<google.auth.version>0.6.0</google.auth.version>
<grpc.version>1.0.3</grpc.version>
<gax.version>0.7.0</gax.version>
<gax.version>0.8.0</gax.version>
<generatedProto.version>0.1.5</generatedProto.version>
<core.version>0.10.1-alpha-SNAPSHOT</core.version>
<beta.version>0.10.1-beta-SNAPSHOT</beta.version>
Expand Down
0