Remove deprecated methods and corresponding tests #1678
Conversation
|
It looks like there are javadoc failures in the jdk8 test. I think those should be fixed. Those kind of errors will block the release process. |
|
Seems like we have several javadocs which refer to the deprecated methods. I will go through the repo and fix them. |
|
Changes Unknown when pulling 1bf2b50 on shinfan:dev into ** on GoogleCloudPlatform:master**. |
There was a problem hiding this comment.
I just have a couple nits - you can choose to take care of them in a following PR if you would like.
LGTM after conflicts are resolved - please merge ASAP since this is so large.
| builder.set(valuePb); | ||
| return builder; | ||
| } | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| : valueType.getMarshaller().fromProto(proto).build(); | ||
| } | ||
| } | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| P build(); | ||
| } | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| package com.google.cloud.pubsub.spi.v1; | ||
|
|
||
| import com.google.pubsub.v1.PubsubMessage; | ||
| import java.util.concurrent.BlockingQueue; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling 7441280 on shinfan:dev into ** on GoogleCloudPlatform:master**. |
Remove deprecated methods and its references in one pass by a self-made script, with a few exceptions: - There are still plenty of manual work involved to update usages of deprecated methods and fields - Manual corrections due to misspell of the word "deprecated" - google-cloud-pubsub: Pubsub has a few deprecated packages and it affects its integrated tests as well. Removing deprecated packages is not in the scope of this PR. - google-cloud-compute: Compute engine has a few "Deprecated" related service which causes lots of noise of the automated script. - google-cloud-datastore - In `ValueBuilder` `getExcludeFromIndexes` was marked as deprecated which is inconsistent with other getter/setter methods - Preserved the fields `meaning` in `ValueBuilder` since it is still wide used in the code. May require a separate PR to deprecate.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Update:
Fixed all malformed javadocs including:
Note: I intend to merge this PR soon since it may cause lots of conflicts.
Remove deprecated methods and tests in one pass by a self-made script, with a few exceptions:
ValueBuildergetExcludeFromIndexeswas marked as deprecated which is inconsistent with other getter/setter methodsmeaninginValueBuildersince it is still wide used in the code. May require a separate PR to deprecate.Fixes #1569
Test: All unit tests passed locally.