Enabling client-side compression for Pub/Sub #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@pongad @garrettjonesgoogle for your review |
pongad
reviewed
Feb 22, 2017
Contributor
There was a problem hiding this comment.
Thank you for this! LGTM except possibly the method name called out below.
Please wait for @garrettjonesgoogle to +2.
| * Gives the ability to disable client-side compression. | ||
| * Note compression is enabled by default. | ||
| */ | ||
| public Builder setCompressionEnabled(boolean enabled) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
LGTM too. |
davidtorres
added a commit
to davidtorres/google-cloud-java
that referenced
this pull request
Feb 23, 2017
…on to (googleapis#1645)". Compression is not fully supported in gRPC, can't have it in the library yet. This reverts commit a599972.
davidtorres
added a commit
to davidtorres/google-cloud-java
that referenced
this pull request
Feb 23, 2017
garrettjonesgoogle
pushed a commit
that referenced
this pull request
Feb 23, 2017
|
Hi, Is there any plan to evaluate compression/gzip support again? |
|
I could not quite get, why is this reverted? Could somebody explain, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addressing #1639, changes will need to be made to the gax.grpc classes to support compression.