8000 return Name objects instead of plain String by pongad · Pull Request #1562 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

return Name objects instead of plain String #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pongad merged 3 commits into from
Jan 25, 2017
Merged

return Name objects instead of plain String #1562

pongad merged 3 commits into from
Jan 25, 2017

Conversation

@pongad
Copy link
Contributor
@pongad pongad commented Jan 25, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 25, 2017
@coveralls
Copy link
coveralls commented Jan 25, 2017

Coverage Status

Changes Unknown when pulling 090326c on pongad:return-name into ** on GoogleCloudPlatform:pubsub-hp**.

garrettjonesgoogle
garrettjonesgoogle reviewed Jan 25, 2017
View reviewed changes
...c/main/java/com/google/cloud/examples/pubsub/snippets/CreateSubscriptionAndPullMessages.java
};
Subscriber subscriber = null;
try {
subscriber = Subscriber.Builder.newBuilder(subscription, receiver).build();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java Outdated
private static final Logger logger = LoggerFactory.getLogger(Publisher.class);

private final TopicName topicName;
private final String topic;

This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java Outdated
private static final Logger logger = LoggerFactory.getLogger(Subscriber.class);

private final SubscriptionName subscriptionName;
private final String subscription;

This comment was marked as spam.

Sign in to view

@pongad
Copy link
Contributor Author
pongad commented Jan 25, 2017

@garrettjonesgoogle PTAL

@garrettjonesgoogle
Copy link
Member
garrettjonesgoogle commented Jan 25, 2017

LGTM

@pongad pongad merged commit 16957b0 into googleapis:pubsub-hp Jan 25, 2017
@pongad pongad deleted the return-name branch January 25, 2017 22:59
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@release-please
chore(main): release 3.16.2 (#1562)
e598143 
🤖 I have created a release *beep* *boop*
---


## [3.16.2](https://togithub.com/googleapis/java-logging/compare/v3.16.1...v3.16.2) (2024-03-20)


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.28.0 ([#1560](https://togithub.com/googleapis/java-logging/issues/1560)) ([d52e623](https://togithub.com/googleapis/java-logging/commit/d52e62343aa814183baa4fa8ea39d41a5e7c423f))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.28.1 ([#1563](https://togithub.com/googleapis/java-logging/issues/1563)) ([81aa3e6](https://togithub.com/googleapis/java-logging/commit/81aa3e6b6662d62844b289a22e8aba50dff36a51))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad @coveralls @garrettjonesgoogle @googlebot
0