add Publisher.Settings #1515
Closed
add Publisher.Settings #1515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is used to configure Publisher. User-visible options are made public. Options that should be automatically populated, like user credentials, are left package-private for now.
|
Changes Unknown when pulling 2beb34e on pongad:publisher-settings into ** on GoogleCloudPlatform:pubsub-hp**. |
|
Changes Unknown when pulling 95c9d40 on pongad:publisher-settings into ** on GoogleCloudPlatform:pubsub-hp**. |
pongad
commented
Jan 10, 2017
Contributor
Author
There was a problem hiding this comment.
@garrettjonesgoogle I think I got this mostly right, but I'm completely unfamiliar with the handwritten option classes. PTAL.
| maxBundleMessages = builder.bundlingSettings.getElementCountThreshold(); | ||
| maxBundleBytes = builder.bundlingSettings.getRequestByteThreshold(); | ||
| maxBundleDuration = builder.bundlingSettings.getDelayThreshold(); | ||
| PublisherImpl(String topic, PubSubOptions psOptions, Settings settings) throws IOException { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling 73074a5 on pongad:publisher-settings into ** on GoogleCloudPlatform:pubsub-hp**. |
| maxBundleMessages = builder.bundlingSettings.getElementCountThreshold(); | ||
| maxBundleBytes = builder.bundlingSettings.getRequestByteThreshold(); | ||
| maxBundleDuration = builder.bundlingSettings.getDelayThreshold(); | ||
| PublisherImpl(String topic, PubSubOptions psOptions, Settings settings) throws IOException { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
Is this obsolete or does it need to be rewritten? |
Contributor
Author
|
@garrettjonesgoogle Thanks for pointing this out. This is superseded by us deleting all the hand written parts. |
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
🤖 I have created a release *beep* *boop* --- ## [3.15.16](https://togithub.com/googleapis/java-logging/compare/v3.15.15...v3.15.16) (2024-01-25) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.32.0 ([#1511](https://togithub.com/googleapis/java-logging/issues/1511)) ([e2f574c](https://togithub.com/googleapis/java-logging/commit/e2f574caa0b8c2a2cdb3b186fbf2d599d6ef4c2b)) * Enable v2.LogEntry Protobufs converter functions ([#1509](https://togithub.com/googleapis/java-logging/issues/1509)) ([9ef4d90](https://togithub.com/googleapis/java-logging/commit/9ef4d9048b1ecdc887ebc9cb4898a4bfe3f6c154)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.22.0 ([#1510](https://togithub.com/googleapis/java-logging/issues/1510)) ([b40e846](https://togithub.com/googleapis/java-logging/commit/b40e8465590dadec7c9ff26eb27e92c16b059489)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.23.0 ([#1518](https://togithub.com/googleapis/java-logging/issues/1518)) ([30ba9ed](https://togithub.com/googleapis/java-logging/commit/30ba9ed687f5469d36138a138f68cd998cf60b53)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is used to configure Publisher.
User-visible options are made public.
Options that should be automatically populated,
like user credentials,
are left package-private for now.
Tests for input validation for BundlingSettings
and FlowController are removed.
They should be moved to gax instead.
googleapis/gax-java#168