Pub/Sub SPI: Adding IAM methods and auto-generated unit tests #1219
Conversation
|
A couple of questions on dependencies:
|
|
|
@garrettjonesgoogle another general question: is there a real need for having a copy of |
|
It's the general pattern for IAM. In services that follow the suggested pattern (see https://github.com/googleapis/googleapis/blob/master/google/genomics/v1/datasets.proto ), the methods are redeclared in each service declaration. This allows their documentation and http paths to be customized. Pub/Sub doesn't follow the suggested pattern in the proto declarations, although it shows up the correct way in the http view (see https://developers.google.com/apis-explorer/#p/pubsub/v1/ ). |
|
Will setting the policy for a topic resource via the |
|
The way it's set up currently, it will fail validation when the flattened methods are used, but the request-based methods would not fail. The http endpoints actually have zero impact on the gRPC call; we just use the http endpoint information to inform our codegen (we derive the validation from it). |
|
I am closing this, rebased on top of master in #1229 |
🤖 I have created a release *beep* *boop* --- ## [3.13.5](https://togithub.com/googleapis/java-logging/compare/v3.13.4...v3.13.5) (2022-12-06) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#1219](https://togithub.com/googleapis/java-logging/issues/1219)) ([b54e015](https://togithub.com/googleapis/java-logging/commit/b54e015b13b52bfae0f57242a08c452a74cbfb29)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Note: grpc-google-pubsub-v1 depends on a new package grpc-google-iam-v1, which contains IAMPolicy and Policy.