10000 feat: Generate IAM v3 Library by lqiu96 · Pull Request #11557 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

feat: Generate IAM v3 Library #11557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up fo 10000 r GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 6, 2025
Merged

feat: Generate IAM v3 Library #11557

merged 6 commits into from
May 6, 2025

Conversation

lqiu96
Copy link
Contributor
@lqiu96 lqiu96 commented May 5, 2025

See b/406872289 for more information

@lqiu96 lqiu96 requested a review from a team as a code owner May 5, 2025 19:05
@lqiu96 lqiu96 enabled auto-merge (squash) May 5, 2025 20:07
@lqiu96 lqiu96 requested a review from jinseopkim0 May 5, 2025 20:07
@lqiu96
Copy link
Contributor Author
lqiu96 commented May 5, 2025

Turns out that that the proto/ grpc IAM versions are set by the gapic-generator-bom...

For this release, I will just hardcode the IAM v3 proto and grpc versions so that I don't need to re-release sdk-platform-java. Next release we can remove this workaround have the bom manage the versions.

@lqiu96 lqiu96 mentioned this pull request May 5, 2025
Merged
lqiu96 added a commit to googleapis/sdk-platform-java that referenced this pull request May 5, 2025
@lqiu96
chore: Add IAM v3 to gapic-generator-bom (#3778)
25d9ed1 
Discovered from
googleapis/google-cloud-java#11557 (comment)
@lqiu96 lqiu96 disabled auto-merge May 6, 2025 02:48
@lqiu96 lqiu96 enabled auto-merge (squash) May 6, 2025 17:05
@lqiu96
Copy link
Contributor Author
lqiu96 commented May 6, 2025

Turns out that that the proto/ grpc IAM versions are set by the gapic-generator-bom...

For this release, I will just hardcode the IAM v3 proto and grpc versions so that I don't need to re-release sdk-platform-java. Next release we can remove this workaround have the bom manage the versions.

Actually, do not need to hard-code the versions for this release as I had to re-release sdk-platform-java. IAM v3 has the versions set by the upstream gapic-generator-bom

@lqiu96 lqiu96 merged commit a91ea2f into main May 6, 2025
32 checks passed
@lqiu96 lqiu96 deleted the generate-iam-v3 branch May 6, 2025 18:00
@release-please release-please bot mentioned this pull request May 6, 2025
Merged
ldetmer added a commit that referenced this pull request May 14, 2025
@ldetmer
chore: remove hard-coded versions for iam proto/grpc
7cc895c 
This is based off description here: #11557 (comment)
@ldetmer ldetmer mentioned this pull request May 14, 2025
Merged
ldetmer added a commit that referenced this pull request May 21, 2025
@ldetmer
chore: remove hard-coded versions for iam proto/grpc (#11584)
4d5aad6 
This is based off description here: #11557 (comment)
lqiu96 added a commit to googleapis/sdk-platform-java that referenced this pull request Jun 10, 2025
@lqiu96
chore: Add IAM v3 to gapic-generator-bom (#3778)
ac68dc9 
Discovered from
googleapis/google-cloud-java#11557 (comment)
lqiu96 added a commit that referenced this pull request Jun 10, 2025
@lqiu96 @cloud-java-bot
feat: Generate IAM v3 Library (#11557)
399e650 
* feat: Generate IAM v3 Library

* chore: Add v3 owlbot configs

* chore: generate libraries at Mon May  5 20:02:05 UTC 2025

* chore: Update deps

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
lqiu96 pushed a commit that referenced this pull request Jun 10, 2025
@ldetmer @lqiu96
chore: remove hard-coded versions for iam proto/grpc (#11584)
d0c3d4a 
This is based off description here: #11557 (comment)
lqiu96 added a commit that referenced this pull request Jun 10, 2025
@lqiu96 @cloud-java-bot
feat: Generate IAM v3 Library (#11557)
b51f44f 
* feat: Generate IAM v3 Library

* chore: Add v3 owlbot configs

* chore: generate libraries at Mon May  5 20:02:05 UTC 2025

* chore: Update deps

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
lqiu96 pushed a commit that referenced this pull request Jun 10, 2025
@ldetmer @lqiu96
chore: remove hard-coded versions for iam proto/grpc (#11584)
f59269b 
This is based off description here: #11557 (comment)
lqiu96 added a commit that referenced this pull request Jul 7, 2025
@lqiu96 @cloud-java-bot
feat: Generate IAM v3 Library (#11557)
4875967 
* feat: Generate IAM v3 Library

* chore: Add v3 owlbot configs

* chore: generate libraries at Mon May  5 20:02:05 UTC 2025

* chore: Update deps

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
lqiu96 pushed a commit that referenced this pull request Jul 7, 2025
@ldetmer @lqiu96
chore: remove hard-coded versions for iam proto/grpc (#11584)
bfe49c7 
This is based off description here: #11557 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinseopkim0 jinseopkim0 jinseopkim0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lqiu96 @jinseopkim0 @cloud-java-bot
0