8000 Add useLegacySql support to QueryRequest and QueryJobConfiguration by mziccard · Pull Request #1142 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Add useLegacySql support to QueryRequest and QueryJobConfiguration #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mziccard merged 1 commit into from
Aug 11, 2016
Merged

Add useLegacySql support to QueryRequest and QueryJobConfiguration #1142

mziccard merged 1 commit into from
Aug 11, 2016

Conversation

@mziccard
Copy link
Contributor
@mziccard mziccard commented Aug 8, 2016

This fixes #1137

@tswast does this fit with your needs?

@mziccard mziccard added the api: bigquery Issues related to the BigQuery API. label Aug 8, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2016
@coveralls
Copy link
coveralls commented Aug 8, 2016

Coverage Status

Coverage increased (+0.02%) to 85.883% when pulling 39f6bc0 on mziccard:legacy-sql-support into 64115e4 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author
mziccard commented Aug 8, 2016

/cc @lesv

@lesv
Copy link
Contributor
lesv commented Aug 8, 2016

LGTM - give @tswast a few minutes to comment.

@tswast
Copy link
Contributor
tswast commented Aug 8, 2016

Cool. Would you mind adding an example with use legacy sql set to false in https://github.com/GoogleCloudPlatform/gcloud-java/blob/master/gcloud-java-examples/src/main/java/com/google/cloud/examples/bigquery/BigQueryExample.java#L628 ?

@mziccard
Copy link
Contributor Author
mziccard commented Aug 9, 2016

Would you mind adding an example with use legacy sql set to false

I am not sure useLegacySql or any "experimental" feature should be in the examples (also considering that examples do not cover all query options). In this case I expect useLegacySql to either disappear or be defaulted to false as soon as Standard SQL reaches maturity. However, if you feel strongly about this, I would be glad to add the example.

@tswast
Copy link
Contributor
tswast commented Aug 10, 2016

Okay to merge from me. Discussed offline. We can wait until after standard SQL syntax goes GA before documenting in the examples.

@mziccard mziccard merged commit f9484f3 into googleapis:master Aug 11, 2016
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@renovate-bot @gcf-owl-bot
chore(deps): update dependency com.google.cloud:google-cloud-logging …
77a3152 
…to v3.11.8 (#1142)

* chore(deps): update dependency com.google.cloud:google-cloud-logging to v3.11.8

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery Cannot specify to use Standard SQL instead of Legacy SQL.

5 participants

@mziccard @coveralls @lesv @tswast @googlebot
0