8000
  • fix: replace environment variable GCE_METADATA_ROOT with GCE_METADATA_HOST by michaelawyu · Pull Request #433 · googleapis/google-auth-library-python · GitHub
    [go: up one dir, main page]

    Skip to content
    This repository was archived by the owner on Mar 6, 2026. It is now read-only.

    fix: replace environment variable GCE_METADATA_ROOT with GCE_METADATA_HOST#433

    Merged
    gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
    michaelawyu:env_var
    Jun 4, 2020
    Merged

    fix: replace environment variable GCE_METADATA_ROOT with GCE_METADATA_HOST#433
    gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
    michaelawyu:env_var

    Conversation

    @michaelawyu
    Copy link
    Contributor

    …_HOST

    • keeps consistent naming across auth packages of all languages.

      The package will now check GCE_METADATA_HOST (the new name) first; if not present, it falls back to GCE_METADATA_ROOT (the old name), then the default value.

    closes #339.

    …_HOST
    
    * keeps consistent naming across auth packages of all languages.
    
        The package will now check GCE_METADATA_HOST (the new name) first; if not present, it falls back to GCE_METADATA_ROOT (the old name), then the default value.
    
    closes [googleapis#339](googleapis#339).
    @googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 23, 2020
    @busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 4, 2020
    @busunkim96 busunkim96 changed the title fix: replace environment variable GCE_METADATA_ROOT with GCE_METADATA… fix: replace environment variable GCE_METADATA_ROOT with GCE_METADATA_HOST Jun 4, 2020
    @gcf-merge-on-green gcf-merge-on-green bot merged commit 8ffb4d3 into googleapis:master Jun 4, 2020
    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

    Labels

    automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    GCE_METADATA_ROOT should be called GCE_METADATA_HOST to be aligned with other client libraries

    3 participants

    0