8000 fix: Allow mtls sts endpoint for external account token urls. by clundin25 · Pull Request #1185 · googleapis/google-auth-library-python · GitHub
[go: up one dir, main page]
Skip to content

fix: Allow mtls sts endpoint for external account token urls. #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

< 8000 p class="mt-4 color-fg-muted text-center"> Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2022
Merged

fix: Allow mtls sts endpoint for external account token urls. #1185

merged 3 commits into from
Nov 16, 2022

Conversation

clundin25
Copy link
Contributor

No description provided.

lsirac
lsirac reviewed Nov 15, 2022
View reviewed changes
clundin25
clundin25 commented Nov 15, 2022
View reviewed changes
@clundin25 clundin25 requested a review from lsirac November 16, 2022 21:15
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2022
BigTailWolf
BigTailWolf approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor
@BigTailWolf BigTailWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clundin25 clundin25 merged commit c86dd69 into googleapis:main Nov 16, 2022
@release-please release-please bot mentioned this pull request Nov 16, 2022
Merged
sai-sunder-s
sai-sunder-s reviewed Nov 30, 2022
View reviewed changes
tests/test_external_account.py
"https://us-east-1.sts.googleapis.com",
"https://us-east-1.sts.mtls.googleapis.com",
"https://US-EAST-1.sts.googleapis.com",
"https://sts.us-east-1.googleapis.com",
"https://sts.US-WEST-1.googleapis.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a case for "https://sts.mtls.US-WEST-1.googleapis.com" (if that is allowed)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC MTLS must prefix googleapis.com but I will check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

6C94 @sai-sunder-s sai-sunder-s sai-sunder-s left review comments

@BigTailWolf BigTailWolf BigTailWolf approved these changes

@lsirac lsirac lsirac approved these changes

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clundin25 @BigTailWolf @sai-sunder-s @lsirac @arithmetic1728
0