8000 fix: Validate url domain for aws metadata urls by sai-sunder-s · Pull Request #1174 · googleapis/google-auth-library-python · GitHub
[go: up one dir, main page]

Skip to content

fix: Validate url domain for aws metadata urls #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2022
Merged

fix: Validate url domain for aws metadata urls #1174

merged 2 commits into from
Nov 7, 2022

Conversation

sai-sunder-s
Copy link
Contributor

Updating AWS credential source validation as per new updates in AIP. Make sure the host of url, region_url and imdsv2 session token url belong to AWS metadata server.

@sai-sunder-s sai-sunder-s requested review from arithmetic1728 and a team as code owners November 3, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
< 6863 div class="discussion-sidebar-item sidebar-assignee js-discussion-sidebar-item position-relative js-socket-channel js-updatable-content" data-team-hovercards-enabled data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjExMTAwMjY0MzgiLCJ0IjoxNzUwNzQ0NzQ5fQ==--7dbd669957f1b72fe5b29b20a072687ed193727dbbf6830d188cb9777e86cac0" data-gid="PR_kwDOBB_mG85CKajG" data-url="/googleapis/google-auth-library-python/issues/1174/show_partial?partial=pull_requests%2Fsidebar%2Fshow%2Freviewers" data-channel-event-name="reviewers_updated" >
Reviewers

@lsirac lsirac lsirac approved these changes

@clundin25 clundin25 clundin25 approved these changes

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0