fix: remove faulty version matcher in setup.py#2152
Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom Jun 6, 2023
con-f-use:patch-1
Merged
fix: remove faulty version matcher in setup.py#2152gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom con-f-use:patch-1
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
con-f-use:patch-1
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
I signed your agreement, please fix the commit message yourself, this feels like a you thing (bad contributor experience btw.). It's what the "Allow edits by maintainers" checkbox exists for:
|
`httplib2<1dev` is not a valid version matcher in the sense of PEP 440. fixes #2151
parthea
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httplib2<1devisnota valid version matcher (edit: it is valid, just doesn't parse with distlib) in the sense of PEP 440.It is also considered bad practice to have an upper bound on package versions and installers like pip do not consider development versions in any case (unless explicitly told to).
Fixes #2151