fix!: support IPv6 address as custom GCE_METADATA_HOST #2592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8dbf88e to
c1b0777
Compare
The url for metadata server would fail if user provided IPv6 address as GCE_METADATA_HOST env. For backwards compatibility new code accepts the following: * domain, i.e. `mymetadataserver.domain.com` * domain with port, i.e. `mymetadataserver.domain.com:8080` * IPv4 address, i.e. `127.0.0.1` * IPv4 address with port, i.e. `127.0.0.1:8080` * IPv6 address, i.e. `::1` * IPv6 address within square brackers, i.e. `[::1]` * IPv6 address with port, i.e. `[::1]:8080` BREAKING CHANGE: As the new code performs URL validation, it will fallback to the `DEFAULT_METADATA_SERVER_URL` if provided env variable results in invalid URL (this is behavioral change as prior to it, the malformed URL would be passed to upper layers and result in invalid request attempt). Signed-off-by: Marek Chodor <mchodor@google.com>
c1b0777 to
65bb25e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The url for metadata server would fail if user provided IPv6 address as GCE_METADATA_HOST env.
For backwards compatibility new code accepts the following:
mymetadataserver.domain.commymetadataserver.domain.com:8080127.0.0.1127.0.0.1:8080::1[::1][::1]:8080As the new code performs URL validation, it will fallback to the
DEFAULT_METADATA_SERVER_URLif provided env variable results in invalid URL (this is behavioral change as prior to it, the malformed URL would be passed to upper layers and result in invalid request attempt).Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2591 ☕️
If you write sample code, please follow the samples format.