Merged
Conversation
Some APIs with Cloud Storage integrations seem to have failing samples when non-default scopes are provided. This PR disables the feature globally for now while we investigate. We can no longer rollback da119c7 as some libraries have been released with the change and removing the kwarg would be a breaking change.
arithmetic1728
approved these changes
Jun 28, 2021
parthea
approved these changes
Jun 29, 2021
Contributor
Author
|
@arithmetic1728 @parthea Could I get another review? I looked at this again and the logic seemed off. I added |
arithmetic1728
approved these changes
Jun 29, 2021
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some APIs with Cloud Storage integrations seem to have failing
samples when non-default scopes are provided. This PR disables the feature
globally for now while we investigate.
We can no longer rollback da119c7 as some libraries have been
released with the change and removing the kwarg would be a breaking
change.
See internal issue 192297181 .