[DRAFT] chore: testing constraints target minimum supported versions#2590
[DRAFT] chore: testing constraints target minimum supported versions#2590daniel-sanche wants to merge 5 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates testing against the minimum supported versions of project dependencies. It specifically adjusts the pinned versions of Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request lowers the pinned versions for google-api-core and google-auth in the constraints file for Python 3.9, as part of an effort to test against minimum supported dependency versions. This is a good exploratory change. However, I noticed that the constraints files for Python 3.10, 3.11, and 3.12 currently use _default_constraints.j2, which results in testing against the latest compatible dependency versions rather than the minimums. To ensure consistent and comprehensive testing of the minimum requirements across all supported Python versions, I recommend extending this change to also pin the lower bounds in the constraints files for Python 3.10-3.12.
| and not line.startswith("#") | ||
| and line.strip() | ||
| ] | ||
| session.install("-e", f"{tmp_dir}[async_rest]", *constraints) |
There was a problem hiding this comment.
I'm not super happy with this solution. But the other option is using a separate constraints file for async_rest, and that doesn't seem great either.
Fixes #2568 (comment)
Currently, our constraints files are above the minimum-supported version. We should either get the tests working, or bump up the requirements
This is a DRAFT PR changing the requirements, and we can see what issues come up in tests